feat: chainable extended HTTP assertions on the builder#16
Merged
Conversation
http-assertions.js now also installs queueing wrappers on RequestBuilder for the extended assertions, so they can be chained before awaiting and replay on the resolved response. expectValue is excluded since it returns an Expectation. Types and a unit test added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
The extended HTTP assertions (expectClientError, expectJsonSchema, expectJsonContains, expectCookie, expectSorted, and the rest) are now chainable on the thenable request builder, not only on a resolved GoResponse. They queue and replay on the response like the core assertions.
633 unit tests green, tsc clean.